[dpdk-dev] [PATCH] crypto/qat: fix session initialization

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Wed Jul 19 16:37:08 CEST 2017



> -----Original Message-----
> From: Trahe, Fiona
> Sent: Wednesday, July 19, 2017 3:06 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Jain, Deepak K
> <deepak.k.jain at intel.com>; Griffin, John <john.griffin at intel.com>
> Cc: dev at dpdk.org; Trahe, Fiona <fiona.trahe at intel.com>
> Subject: RE: [PATCH] crypto/qat: fix session initialization
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, July 19, 2017 5:59 AM
> > To: Trahe, Fiona <fiona.trahe at intel.com>; Jain, Deepak K
> > <deepak.k.jain at intel.com>; Griffin, John <john.griffin at intel.com>
> > Cc: dev at dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch at intel.com>
> > Subject: [PATCH] crypto/qat: fix session initialization
> >
> > When creating a session, if there is a failure when setting some of
> > the parameters, QAT was not propagating the error to the session
> > initialization function.
> > Therefore, it was reporting a success, when it should be report a
> > failure.
> >
> > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> In the 3 fn prototypes in qat_crypto.h it would be nice to remove the
> _private from struct qat_session *session_private. Apart from that it's fine.
> 
> Acked-by: Fiona Trahe <iona.trahe at intel.com>

I fixed that when merging the patch :) Thanks!

Applied to dpdk-next-crypto.

Pablo


More information about the dev mailing list