[dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Wed Jul 26 17:17:42 CEST 2017



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:54 PM
> To: dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
> 
> If there's no Traffic Management node added,
> not necessary to check if TM is committed.
> 
> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..e436dca 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
>  	ixgbe_l2_tunnel_conf(dev);
>  	ixgbe_filter_restore(dev);
> 
> -	if (!tm_conf->committed)
> +	if (tm_conf->root && !tm_conf->committed)
>  		PMD_DRV_LOG(WARNING,
>  			    "please call hierarchy_commit() "
>  			    "before starting the port");
> --
> 1.9.3

Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>




More information about the dev mailing list