[dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call

Yongseok Koh yskoh at mellanox.com
Fri Jul 28 02:26:54 CEST 2017


> On Jul 27, 2017, at 4:12 AM, Sagi Grimberg <sagi at grimberg.me> wrote:
> 
> 
>>> Yes I realize that, but can't the device still complete in a burst (of
>>> unsuppressed completions)? I mean its not guaranteed that for every
>>> txq_complete a signaled completion is pending right? What happens if
>>> the device has inconsistent completion pacing? Can't the sw grow a
>>> batch of completions if txq_complete will process a single completion
>>> unconditionally?
>> Speculation. First of all, device doesn't delay completion notifications for no
>> reason. ASIC is not a SW running on top of a OS.
> 
> I'm sorry but this statement is not correct. It might be correct in a
> lab environment, but in practice, there are lots of things that can
> affect the device timing.
Disagree.

[...]
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
Thanks for ack!

Yongseok


More information about the dev mailing list