[dpdk-dev] [PATCH] ethdev: fix invalid length write on dev detach

[Gaëtan Rivet]

On Mon, Jul 31, 2017 at 03:27:29PM +0200, Thomas Monjalon wrote:
> 31/07/2017 12:29, Gaetan Rivet:
> > The name of a device is copied in a provided buffer within
> > rte_eth_dev_detach(). The current sizeof is done on a pointer instead of
> > the intended array usually pointed to.
> > 
> > The name field of an rte_device is not assured however to point an
> > rte_devargs name field. The almost correct length to base this copy over
> > is thus RTE_DEV_NAME_MAX_LEN.
> > 
> > Almost correct, because unfortunately this function does not allow the
> > user to pass down a size parameter for the buffer it is meant to write.
> > This API should be fixed, it is broken by design.
> 
> Yes we must discuss the future of this API function.
> 
> In the meantime, this limitation (size expectation) should be documented
> in the doxygen comment. v2 please?
> 

Sure

-- 
Gaëtan Rivet
6WIND