[dpdk-dev] [dpdk-stable] [PATCH] net/mlx4: fix probe failure report

Ferruh Yigit ferruh.yigit at intel.com
Mon Jul 31 19:09:12 CEST 2017


On 7/31/2017 3:30 PM, Matan Azrad wrote:
> The corrupted code doesn't return error when probe function
> fails due to error in device mac address getting.
> By this way, the probe function may return success even if the
> ETH dev is not allocated.
> 
> Hence, the probe caller, for example failsafe PMD, fails when it
> tries to get ETH dev after the device was plugged out while mlx4
> was probing it.
> 
> The fix adds error report to the probe caller when priv_get_mac fails
> and in all other failure options which are missing it.
> 
> By this way, it prevents the unexpected behavior to miss ETH device
> after the device was probed successfully.
> 
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
> Fixes: 001a520e419f ("net/mlx4: add port parameter")
> Fixes: 7b0661539229 ("mlx4: check if port is configured for ethernet")
> Fixes: fec3608673e6 ("mlx4: query netdevice to get initial MAC address")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Matan Azrad <matan at mellanox.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list