[dpdk-dev] [PATCH 00/12] Remove cryptodev driver
Gaëtan Rivet
gaetan.rivet at 6wind.com
Thu Jun 8 00:54:41 CEST 2017
Hi Pablo,
On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote:
> Following the same aproach taken for ethdev, this patch series
> removes the PCI specific structure cryptodev driver from rte_cryptodev.
>
> The patchset makes the following changes:
>
> - Moves the virtual and PCI device specific functions to separate files,
> so other cryptodev header files contain only device type agnostic functions.
>
> - Modifies device info retrieval function to set the driver name for all devices
> and set PCI info inside PCI device PMDs
>
> - Removes cryptodev driver structure from cryptodev library and drivers
> that were using it (QAT and dpaa2)
>
While most of the work seems to be done within this patchset, there are
still rte_pci.h includes in both:
lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h>
lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h>
This breaks the compilation when the PCI bus is compiled outside the EAL.
Would you be able to remove those last dependencies?
> There is still a vdev specific function, rte_cryptodev_create_vdev() in cryptodev.c.
> That function should be deprecated, as virtual devices should be created through
> EAL. A deprecation notice will be sent separately.
>
> Pablo de Lara (12):
> cryptodev: store device pointer in virtual devices
> cryptodev: set driver name for all devices
> cryptodev: rename device retrieval argument
> cryptodev: simplify device list retrieval logic
> cryptodev: only set PCI info when device is PCI
> cryptodev: move vdev functions to a separate file
> cryptodev: release device if PCI device probing fails
> cryptodev: add PCI driver helpers
> crypto/qat: do not use cryptodev driver
> crypto/dpaa2_sec: do not use cryptodev driver
> cryptodev: remove unused PCI probe/remove
> cryptodev: remove unused cryptodev driver
>
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +-
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 5 +-
> drivers/crypto/armv8/rte_armv8_pmd.c | 4 +-
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 9 +-
> drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 +-
> drivers/crypto/null/null_crypto_pmd.c | 8 +-
> drivers/crypto/openssl/rte_openssl_pmd.c | 4 +-
> drivers/crypto/qat/qat_crypto.c | 6 +-
> drivers/crypto/qat/qat_qp.c | 8 +-
> drivers/crypto/qat/rte_qat_cryptodev.c | 32 +--
> drivers/crypto/scheduler/scheduler_pmd.c | 59 +-----
> drivers/crypto/scheduler/scheduler_pmd_ops.c | 1 +
> drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 +-
> drivers/crypto/zuc/rte_zuc_pmd.c | 4 +-
> lib/librte_cryptodev/Makefile | 2 +
> lib/librte_cryptodev/rte_cryptodev.c | 272 +------------------------
> lib/librte_cryptodev/rte_cryptodev.h | 39 +---
> lib/librte_cryptodev/rte_cryptodev_pci.h | 177 ++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 94 ---------
> lib/librte_cryptodev/rte_cryptodev_vdev.h | 236 +++++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_version.map | 18 +-
> 21 files changed, 497 insertions(+), 493 deletions(-)
> create mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h
> create mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h
>
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
More information about the dev
mailing list