[dpdk-dev] [PATCH 00/12] Remove cryptodev driver

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Thu Jun 8 17:58:16 CEST 2017


Hi Gaetan,

> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet at 6wind.com]
> Sent: Wednesday, June 07, 2017 11:55 PM
> To: De Lara Guarch, Pablo
> Cc: Doherty, Declan; thomas at monjalon.net; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
> 
> Hi Pablo,
> 
> On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote:
> > Following the same aproach taken for ethdev, this patch series
> > removes the PCI specific structure cryptodev driver from rte_cryptodev.
> >
> > The patchset makes the following changes:
> >
> > - Moves the virtual and PCI device specific functions to separate files,
> >   so other cryptodev header files contain only device type agnostic
> functions.
> >
> > - Modifies device info retrieval function to set the driver name for all
> devices
> >   and set PCI info inside PCI device PMDs
> >
> > - Removes cryptodev driver structure from cryptodev library and drivers
> >   that were using it (QAT and dpaa2)
> >
> 
> While most of the work seems to be done within this patchset, there are
> still rte_pci.h includes in both:
> 
> lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h>
> lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h>
> 
> This breaks the compilation when the PCI bus is compiled outside the EAL.
> Would you be able to remove those last dependencies?

These includes have been removed already in the patchset.
Have you applied all 12 patches?

Thanks,
Pablo




More information about the dev mailing list