[dpdk-dev] [PATCH] net/liquidio: do not touch mbuf initialized fields

[Ferruh Yigit]

On 6/8/2017 12:22 PM, Shijith Thotton wrote:
> Avoid re-initializing of mbuf fields which are set while in pool.
> Replaced lio_recv_buffer_alloc with rte_pktmbuf_alloc.
> 
> See commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool").
> 
> Signed-off-by: Shijith Thotton <shijith.thotton at caviumnetworks.com>

<...>

> @@ -489,9 +466,6 @@
>  			droq->refill_count++;
>  
>  			if (likely(nicbuf != NULL)) {
> -				nicbuf->data_off = RTE_PKTMBUF_HEADROOM;

Hi Shijith, Olivier,

nb_segs and next are initialized properly when mbuf allocated, but is
"data_off = RTE_PKTMBUF_HEADROOM" guaranteed?

> -				nicbuf->nb_segs = 1;
> -				nicbuf->next = NULL;
>  				/* We don't have a way to pass flags yet */
>  				nicbuf->ol_flags = 0;
>  				if (rh->r_dh.has_hash) {

<...>