[dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header
Gaëtan Rivet
gaetan.rivet at 6wind.com
Wed Jun 14 11:48:28 CEST 2017
Hi,
On Wed, Jun 14, 2017 at 09:33:14AM +0000, Dai, Wei wrote:
> Why to introduce this change ?
>
> Even without this patch, all files can be built successfully.
> Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and without this patch.
> So there is no need to add the line at least in the config of x86_64-native-linuxapp-gcc.
>
>
In order to remove the PCI bus from the EAL, I need to remove all
references to it from EAL headers.
rte_devargs.h previously included rte_pci.h, which then was included by
several other parts of the DPDK.
This needs to be fixed, as afterward, the commit
* devargs: generic device representation
removes the PCI include.
This include was faulty anyway, as normally all compile units (or at
least independent DPDK parts) should be self-sufficient in terms of includes,
due to this exact situation where libraries are moved around and their
dependencies are updated.
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gaetan Rivet
> > Sent: Thursday, June 8, 2017 7:57 AM
> > To: dev at dpdk.org
> > Cc: Gaetan Rivet <gaetan.rivet at 6wind.com>
> > Subject: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header
> >
> > Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> > b/drivers/net/ixgbe/ixgbe_ethdev.h
> > index e2d0139..bb5ecd5 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> > @@ -39,6 +39,7 @@
> > #include "ixgbe_bypass.h"
> > #include <rte_time.h>
> > #include <rte_hash.h>
> > +#include <rte_pci.h>
> >
> > /* need update link, bit flag */
> > #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)
> > --
> > 2.1.4
>
--
Gaëtan Rivet
6WIND
More information about the dev
mailing list