[dpdk-dev] [PATCH] vfio: allow to map other memory regions

[Thomas Monjalon]

Hi,
Some comments below

24/05/2017 13:17, Pawel Wodkowski:
> Currently it is not possible to use memory that is not owned by DPDK to
> perform DMA. This scenarion might be used in vhost applications (like
> SPDK) where guest send its own memory table. To fill this gap provide
> API to allow registering arbitrary address in VFIO container.
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski at intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/Makefile            |   3 +
>  lib/librte_eal/linuxapp/eal/eal_vfio.c          | 142 +++++++++++++++++++++---
>  lib/librte_eal/linuxapp/eal/eal_vfio.h          |  10 ++
>  lib/librte_eal/linuxapp/eal/include/rte_iommu.h |  78 +++++++++++++
>  lib/librte_eal/linuxapp/eal/rte_eal_version.map |   8 ++
>  5 files changed, 224 insertions(+), 17 deletions(-)
>  create mode 100644 lib/librte_eal/linuxapp/eal/include/rte_iommu.h

VFIO is not referenced in the doxygen of these functions.
Could we use this API for something else than VFIO?

Any API should be declared in common directory, even if it is not
implemented for FreeBSD (returning -ENOTSUP).