[dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var

Yuanhan Liu yliu at fridaylinux.org
Tue Jun 20 10:22:56 CEST 2017


On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote:
> 20/06/2017 06:14, santosh:
> > On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote:
> > 
> > > 08/06/2017 16:28, Santosh Shukla:
> > >> Let test_mbuf alloc and free mempool.
> > >>
> > >> Cc: stable at dpdk.org
> > >> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> > > Why Cc stable?
> > > Is it fixing something?
> > >
> > w/o this fix, application can't run more than once.
> > Reason: Static allocation of resources and exiting w/o freeing so leak.
> > 
> > Patch makes app resource handling dynamic and Now user could run
> > test more than once and app exits gracefully. thats why Cc: stable a need (IHMO).
> > Thanks.
> 
> OK
> So we need a Fixes: tag in order to be able to guess which
> release it should be backported to.

Also, I would suggest you to include above info (the real issue) in
the commit log.

	--yliu


More information about the dev mailing list