[dpdk-dev] [PATCH v2 0/4] Socket ID check removal

Pablo de Lara pablo.de.lara.guarch at intel.com
Wed Jun 21 07:07:29 CEST 2017


Several libraries, drivers and tests check if a socket
is within the range of available sockets, by
implementig their own function, which returns the total 
number of sockets that have memory.

First of all, this function is not completely correct,
as it really returns the highest socket id that has memory.
So, if all the sockets up to that one has memory, then it
really returns the total number of sockets with memory,
but if there is at least one in the middle without memory,
then total number of sockets should be less than the value returned.

Besides, this function is not really useful, as the main goal is
to check if memory on a specific socket is available, rather than
checking if a socket id is beyond the total number of sockets.

Therefore, it is better to remove the check and let the memory
allocation function handle an incorrect socket.

Changes in v2:

- Removed new EAL function and just removed the socket id check,
  instead of creating a new function.

Pablo de Lara (4):
  cryptodev: remove socket id check
  crypto/scheduler: remove socket id check
  net/bonding: remove socket id check
  test/bonding: remove socket id check

 drivers/crypto/scheduler/scheduler_pmd.c   | 22 ----------------------
 drivers/net/bonding/rte_eth_bond_api.c     | 16 ----------------
 drivers/net/bonding/rte_eth_bond_args.c    |  4 ++--
 drivers/net/bonding/rte_eth_bond_pmd.c     |  6 ------
 drivers/net/bonding/rte_eth_bond_private.h |  3 ---
 lib/librte_cryptodev/rte_cryptodev.c       | 22 ----------------------
 test/test/virtual_pmd.c                    | 17 -----------------
 7 files changed, 2 insertions(+), 88 deletions(-)

-- 
2.9.4



More information about the dev mailing list