[dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test application

[Van Haaren, Harry]

> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Sunday, May 28, 2017 8:59 PM
> To: dev at dpdk.org
> Cc: Richardson, Bruce <bruce.richardson at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; hemant.agrawal at nxp.com; Eads, Gage <gage.eads at intel.com>;
> nipun.gupta at nxp.com; Vangati, Narender <narender.vangati at intel.com>; Rao, Nikhil
> <nikhil.rao at intel.com>; gprathyusha at caviumnetworks.com; Mcnamara, John
> <john.mcnamara at intel.com>; Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test application
> 
> From: Guduri Prathyusha <gprathyusha at caviumnetworks.com>
> 
> Add documentation to describe usage of eventdev test application and
> supported command line arguments.
> 
> CC: John McNamara <john.mcnamara at intel.com>
> Signed-off-by: Guduri Prathyusha <gprathyusha at caviumnetworks.com>
> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>

Some comments inline below, but overall good docs;


Acked-by: Harry van Haaren <harry.van.haaren at intel.com>


> +
> +* ``--plcore <n>``
> +
> +        Set the producer lcore id.


There is --plcores (note the added "S") just below. Should standardize to one. Double check with the app - I had some issues with plcore(s) not working as expected.

> +
> +* ``--slcore <n>``
> +
> +        Set the scheduler lcore id.(Valid when eventdev is not
> RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capable)
> +
> +* ``--plcores <CORELIST>``
> +
> +        Set the list of cores to be used as producers.
> +
> +* ``--wlcores <CORELIST>``
> +
> +        Set the list of cores to be used as workers.
> +
> +* ``--stlist <type_list>``
> +
> +        Set the scheduled type of each stage where ``type_list`` size
> +        determines the number of stages used in the test application.
> +        Each type_list member can be one of the following::
> +
> +            P or p : Parallel schedule type
> +            O or o : Ordered schedule type
> +            A or a : Atomic schedule type
> +
> +        Application expects the ``type_list`` in comma separated form (i.e. ``--stlist
> o,a,a,a``)
> +
> +* ``--nb_flows <n>``
> +
> +        Set the number of flows to produce.
> +
> +* ``--nb_packets <n>``
> +
> +        Set the number of packets to produce.


I think "--nb_pkts" is the correct string, not "packets"?