[dpdk-dev] [PATCH v5 3/7] vdev: implement parse bus operation

Bruce Richardson bruce.richardson at intel.com
Tue Jun 27 17:59:39 CEST 2017


On Wed, Jun 21, 2017 at 01:30:32AM +0200, Gaetan Rivet wrote:
> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
>  lib/librte_eal/common/eal_common_vdev.c | 60 +++++++++++++++++----------------
>  1 file changed, 31 insertions(+), 29 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c
> index 22e4640..8dd4c88 100644
> --- a/lib/librte_eal/common/eal_common_vdev.c
> +++ b/lib/librte_eal/common/eal_common_vdev.c
> @@ -104,6 +104,29 @@ static char *parse_driver_arg(const char *args)
>  	return str;
>  }
>  
> +/*
> + * typeof(addr): (struct rte_vdev_driver **)
> + */
> +static int
> +vdev_parse(const char *name, void *addr)
> +{
> +	struct rte_vdev_driver **out = addr;
> +	struct rte_vdev_driver *driver = NULL;
> +
> +	TAILQ_FOREACH(driver, &vdev_driver_list, next) {
> +		if (!strncmp(driver->driver.name, name,
> +			     strlen(driver->driver.name)))
> +			break;
> +		if (driver->driver.alias &&
> +		    !strncmp(driver->driver.alias, name,
> +			     strlen(driver->driver.alias)))
> +			break;
> +	}
> +	if (addr != NULL)
> +		*out = driver;
> +	return !driver;
> +}
> +
Prefer == 0 to use of "!" in return value from strncmp. Otherwise:

Acked-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the dev mailing list