[dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

[Stephen Hemminger]

On Mon, 26 Jun 2017 10:42:13 +0100
Radu Nicolau <radu.nicolau at intel.com> wrote:

> From: Michal Jastrzebski <michalx.k.jastrzebski at intel.com>
> 
> If-MIB xstats:
> ifNumber
> ifIndex
> ifType
> ifMtu
> ifSpeed
> ifPhysAddress
> ifOperStatus
> ifLastChange
> ifHighSpeed
> ifConnectorPresent
> ifCounterDiscontinuityTime
> 
> EtherLike-MIB xstats:
> dot3PauseOperMode
> dot3StatsDuplexStatus
> dot3StatsRateControlAbility
> dot3StatsRateControlStatus
> dot3ControlFunctionsSupported
> 
> -updated in v2: coding style
> 
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>
> Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski at intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>

Although this maybe the easiest way for Intel, and satisfy a specific user's
request. It is not a good way forward for the DPDK project.

This must be generic, not specific to device drivers.
If implementing a MIB variable  requires more information than ethdev API
has now, then extend ethdev API first.

One of the common things in open source projects, is that when you want
to add one new feature for one constrained portion; the maintainers require
you to implement a generic solution. This falls into that category.