[dpdk-dev] [PATCH v5 12/19] devargs: generic device representation
Thomas Monjalon
thomas at monjalon.net
Wed Jun 28 09:44:18 CEST 2017
21/06/2017 01:35, Gaetan Rivet:
> Remove the dependency of this subsystem upon bus specific device
> representation.
>
> Devargs only validates that a device declaration is correct and handled
> by a bus. The device interpretation is done afterward within the bus.
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
> app/test-pmd/testpmd.c | 9 ++----
> lib/librte_eal/common/eal_common_devargs.c | 48 +++++------------------------
> lib/librte_eal/common/eal_common_pci.c | 9 ++++--
> lib/librte_eal/common/eal_common_vdev.c | 17 +++++-----
> lib/librte_eal/common/include/rte_devargs.h | 16 ++--------
> lib/librte_eal/common/include/rte_vdev.h | 2 +-
> test/test/test_devargs.c | 9 ++----
> 7 files changed, 30 insertions(+), 80 deletions(-)
Is it correct to add this change when rebasing?
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -533,7 +533,7 @@ pci_plug(struct rte_devargs *da)
struct rte_pci_device *pdev;
struct rte_pci_addr *addr;
- addr = &da->pci.addr;
+ da->bus->parse(da->name, &addr);
/*
* Update eventual pci device in global list.
* Insert it if none was found.
More information about the dev
mailing list