[dpdk-dev] [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD
Jerin Jacob
jerin.jacob at caviumnetworks.com
Thu Jun 29 13:03:02 CEST 2017
-----Original Message-----
> Date: Thu, 29 Jun 2017 15:57:44 +0530
> From: Nipun Gupta <nipun.gupta at nxp.com>
> To: dev at dpdk.org
> CC: hemant.agrawal at nxp.com, jerin.jacob at caviumnetworks.com,
> harry.van.haaren at intel.com, bruce.richardson at intel.com,
> gage.eads at intel.com, shreyansh.jain at nxp.com, Nipun Gupta
> <nipun.gupta at nxp.com>
> Subject: [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD
> X-Mailer: git-send-email 1.9.1
>
> The following patch set adds NXP DPAA2 HW based eventdev
> implementation to the next-eventdev tree.
>
> The patchset consists of the following:
> - DPCON support required by DPAA2 eventdev
> - DPCI support in fslmc bus
> - Interrupt support in QBMAN
> - Implemetation of eventdev API's for DPAA2
> - Documentation of DPAA2 eventdev PMD
Overall it looks good.
There are a few check-git log and check-patch errors. Please send the
next version with fixes that makes sense.
If there are no more review comments. I will pull the next version in a week for
eventdev-next.
Wrong headline prefix:
drivers: add bus dependency for event
fslmc/bus: add interrupt enabling routine
### bus/fslmc: enable portal interrupt handling
WARNING:NAKED_SSCANF: unchecked sscanf return value
#93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175:
+ sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x",
&timeout);
WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
#93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175:
+ sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x",
&timeout);
total: 0 errors, 2 warnings, 247 lines checked
>
> Changes in v4:
> Fixed doxygen warning
>
> Changes in v3:
> Rebased to dpdk master branch
> Fix shared library parallel build (patch 01/21)
> Fixed a checkpatch error
>
> Changes in v2:
> Rebase to latest dpdk-next-eventdev
> Update to support only atomic and ordered queues
> Fix checkpatch errors
>
> Hemant Agrawal (3):
> drivers: add bus dependency for event
> bus/fslmc: generic framework for mc object creation
> bus/fslmc: export qbman dqrr funcs for eventdev usages
>
> Nipun Gupta (18):
> event/dpaa2: add basic build infrastructure
> bus/fslmc: integrating dpio and dpbp to object framework
> bus/fslmc: adding basic dpcon support
> event/dpaa2: register dpcon as dpaa2 device for bus scan
> bus/fslmc: adding basic dpci support
> bus/fslmc: register dpci as dpaa2 device for bus scan
> bus/fslmc: adding cpu support in stashing config
> event/dpaa2: add initialization of event device
> bus/fslmc: add support for static dequeue from portal
> event/dpaa2: add configuration functions
> bus/fslmc: support enqueue with multiple enqueue descriptors
> bus/fslmc: add callback per queue to enable
> bus/fslmc: change func argument to const to avoid warning
> event/dpaa2: add enqueue and dequeue functionality
> fslmc/bus: add interrupt enabling routine
> bus/fslmc: enable portal interrupt handling
> event/dpaa2: handle timeout using interrupts in dequeue
> doc: add NXP DPAA2 EVENTDEV details
>
> MAINTAINERS | 5 +
> config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 +
> doc/guides/eventdevs/dpaa2.rst | 175 ++++++
> doc/guides/eventdevs/index.rst | 1 +
> drivers/Makefile | 1 +
> drivers/bus/fslmc/Makefile | 5 +-
> drivers/bus/fslmc/fslmc_vfio.c | 69 +-
> drivers/bus/fslmc/fslmc_vfio.h | 47 +-
> drivers/bus/fslmc/mc/dpci.c | 307 +++++++++
> drivers/bus/fslmc/mc/dpcon.c | 230 +++++++
> drivers/bus/fslmc/mc/dpio.c | 44 ++
> drivers/bus/fslmc/mc/fsl_dpci.h | 404 ++++++++++++
> drivers/bus/fslmc/mc/fsl_dpci_cmd.h | 147 +++++
> drivers/bus/fslmc/mc/fsl_dpcon.h | 238 +++++++
> drivers/bus/fslmc/mc/fsl_dpcon_cmd.h | 175 ++++++
> drivers/bus/fslmc/mc/fsl_dpio.h | 30 +
> drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 14 +-
> drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 179 ++++++
> drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 133 +++-
> drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 5 +
> drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 28 +-
> drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 46 +-
> drivers/bus/fslmc/qbman/qbman_portal.c | 94 ++-
> drivers/bus/fslmc/rte_bus_fslmc_version.map | 18 +
> drivers/event/Makefile | 2 +
> drivers/event/dpaa2/Makefile | 60 ++
> drivers/event/dpaa2/dpaa2_eventdev.c | 691 +++++++++++++++++++++
> drivers/event/dpaa2/dpaa2_eventdev.h | 114 ++++
> drivers/event/dpaa2/dpaa2_hw_dpcon.c | 139 +++++
> .../event/dpaa2/rte_pmd_dpaa2_event_version.map | 3 +
> mk/rte.app.mk | 1 +
> 31 files changed, 3370 insertions(+), 41 deletions(-)
> create mode 100644 doc/guides/eventdevs/dpaa2.rst
> create mode 100644 drivers/bus/fslmc/mc/dpci.c
> create mode 100644 drivers/bus/fslmc/mc/dpcon.c
> create mode 100644 drivers/bus/fslmc/mc/fsl_dpci.h
> create mode 100644 drivers/bus/fslmc/mc/fsl_dpci_cmd.h
> create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon.h
> create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon_cmd.h
> create mode 100644 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
> create mode 100644 drivers/event/dpaa2/Makefile
> create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.c
> create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.h
> create mode 100644 drivers/event/dpaa2/dpaa2_hw_dpcon.c
> create mode 100644 drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map
>
> --
> 1.9.1
>
More information about the dev
mailing list