[dpdk-dev] [PATCH 25/38] net/dpaa: add support for MTU update

[Ferruh Yigit]

On 6/29/2017 3:56 PM, Shreyansh Jain wrote:
> On Wednesday 28 June 2017 09:15 PM, Ferruh Yigit wrote:
>> On 6/16/2017 6:40 AM, Shreyansh Jain wrote:
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>

<...>

>>> +	dev->data->dev_conf.rxmode.jumbo_frame = 0;
>>> +
>>> +	dev->data->dev_conf.rxmode.max_rx_pkt_len = mtu;
>>
>> I think this only makes sense when jumbo_frame is 1, although not hurts
>> to set...
> 
> Yes, that is true. But, I though it would be better for debugging 
> purpose. Does it hurt keeping it?

It is OK, specially since you are updating the code in jumbo frame patch
to use this variable..

> 
>>
>>> +	return 0;
>>> +}
>> <...>
>>
>>
>