[dpdk-dev] [PATCH] app/testpmd:add bond type description
Declan Doherty
declan.doherty at intel.com
Fri Jun 30 17:39:08 CEST 2017
On 30/06/17 08:56, RongQiang Xie wrote:
> In function cmd_show_bonding_config_parsed() used number represent
> the bond type,in order more detailed,add bond type description
> otherwise we may confused about the number type.
> And also,the primary port just use in mode active backup and tlb,
> so,when the mode is active backup or tlb show the primary port info
> may be more appropriate.
>
> Signed-off-by: RongQiang Xie <xie.rongqiang at zte.com.cn>
> ---
> app/test-pmd/cmdline.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index ff8ffd2..45845a4 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4390,7 +4390,9 @@ static void cmd_show_bonding_config_parsed(void *parsed_result,
> printf("\tFailed to get bonding mode for port = %d\n", port_id);
> return;
> } else
> - printf("\tBonding mode: %d\n", bonding_mode);
> + printf("\tBonding mode: %d ", bonding_mode);
> + printf("[0:Round Robin, 1:Active Backup, 2:Balance, 3:Broadcast, ");
> + printf("\n\t\t\t4:802.3AD, 5:Adaptive TLB, 6:Adaptive Load Balancing]\n");
>
Good idea, but it would be clearer if we just returned the actual mode
string so the user doesn't need to parse it themselves, like below.
- } else
- printf("\tBonding mode: %d ", bonding_mode);
- printf("[0:Round Robin, 1:Active Backup, 2:Balance, 3:Broadcast, ");
- printf("\n\t\t\t4:802.3AD, 5:Adaptive TLB, 6:Adaptive Load
Balancing]\n");
+ }
+
+ printf("\tBonding mode: %d (", bonding_mode);
+ switch (bonding_mode) {
+ case BONDING_MODE_ROUND_ROBIN:
+ printf("round-robin");
+ break;
+ case BONDING_MODE_ACTIVE_BACKUP:
+ printf("active-backup");
+ break;
+ case BONDING_MODE_BALANCE:
+ printf("link-aggregation");
+ break;
+ case BONDING_MODE_BROADCAST:
+ printf("broadcast");
+ break;
+ case BONDING_MODE_8023AD:
+ printf("link-aggregation-802.3ad");
+ break;
+ case BONDING_MODE_TLB:
+ printf("transmit-load-balancing");
+ break;
+ case BONDING_MODE_ALB:
+ printf("adaptive-load-balancing");
+ break;
+ default:
+ printf("unknown-mode");
+ }
+ printf(")\n");
> if (bonding_mode == BONDING_MODE_BALANCE) {
> int balance_xmit_policy;
> @@ -4454,12 +4456,15 @@ static void cmd_show_bonding_config_parsed(void *parsed_result,
>
> }
>
> - primary_id = rte_eth_bond_primary_get(port_id);
> - if (primary_id < 0) {
> - printf("\tFailed to get primary slave for port = %d\n", port_id);
> - return;
> - } else
> + if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP ||
> + bonding_mode == BONDING_MODE_TLB) {
> + primary_id = rte_eth_bond_primary_get(port_id);
> + if (primary_id < 0) {
> + printf("\tFailed to get primary slave for port = %d\n", port_id);
> + return;
> + }
> printf("\tPrimary: [%d]\n", primary_id);
> + }
>
> }
>
>
More information about the dev
mailing list