[dpdk-dev] [PATCH] net/mlx: update C compliance standard
Yongseok Koh
yskoh at mellanox.com
Fri Jun 30 20:14:56 CEST 2017
> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>> This commit addresses a compilation issue against Glibc >= 2.25, which
>> implements assert() through a nonstandard ({ }) construct. Such constructs
>> can normally not be used without __extension__ keyword when -pedantic is
>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode.
>>
>> While assert.h checks for the compiler ability to support GNU extensions,
>> Clang, unlike GCC, does not allow the above syntax when combining
>> -std=gnu99 with -pedantic.
>>
>> Work around missing keyword by moving these PMDs to a stricter compliance
>> standard without GNU extensions but properly checked by Glibc. Doing so is
>> supported on the DPDK side since includes have been cleaned up.
>>
>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
>
> Applied to dpdk-next-net/master, thanks.
This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!
Thanks,
Yongseok
More information about the dev
mailing list