[dpdk-dev] [PATCH v7 08/17] test: change params to distributor autotest

Hunt, David david.hunt at intel.com
Wed Mar 1 11:06:03 CET 2017


On 24/2/2017 2:14 PM, Bruce Richardson wrote:
> On Tue, Feb 21, 2017 at 03:17:44AM +0000, David Hunt wrote:
>> In the next few patches, we'll want to test old and new API,
>> so here we're allowing different parameters to be passed to
>> the tests, instead of just a distributor struct.
>>
>> Signed-off-by: David Hunt <david.hunt at intel.com>
>> ---
>>   app/test/test_distributor.c | 64 +++++++++++++++++++++++++++++----------------
>>   1 file changed, 42 insertions(+), 22 deletions(-)
>>
>> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
>> index 6a4e20b..fdfa793 100644
>> --- a/app/test/test_distributor.c
>> +++ b/app/test/test_distributor.c
>> @@ -45,6 +45,13 @@
>>   #define BURST 32
>>   #define BIG_BATCH 1024
>>   
>> +struct worker_params {
>> +	char name[64];
>> +	struct rte_distributor_v20 *dist;
>> +};
>> +
>> +struct worker_params worker_params;
>> +
>>   /* statics - all zero-initialized by default */
>>   static volatile int quit;      /**< general quit variable for all threads */
>>   static volatile int zero_quit; /**< var for when we just want thr0 to quit*/
>> @@ -81,7 +88,8 @@ static int
>>   handle_work(void *arg)
>>   {
>>   	struct rte_mbuf *pkt = NULL;
>> -	struct rte_distributor_v20 *d = arg;
>> +	struct worker_params *wp = arg;
>> +	struct rte_distributor_v20 *d = wp->dist;
> The cover letter indicated that using new vs old API was just a matter
> of passing a different parameter to create. I therefore would not expect
> to see references to v20 APIs or structures in any code outside the lib
> itself. Am I missing something?
>
> /Bruce
>

Patchset has now been reworked so the api switches over and apps 
migrated to new SPI in one step, so _v20 never exposed.

Dave.



More information about the dev mailing list