[dpdk-dev] [PATCH v1 06/14] ring: remove watermark support
Bruce Richardson
bruce.richardson at intel.com
Wed Mar 1 11:43:43 CET 2017
On Wed, Mar 01, 2017 at 11:34:57AM +0100, Olivier Matz wrote:
> On Thu, 23 Feb 2017 17:23:59 +0000, Bruce Richardson <bruce.richardson at intel.com> wrote:
> > Remove the watermark support. A future commit will add support for having
> > enqueue functions return the amount of free space in the ring, which will
> > allow applications to implement their own watermark checks, while also
> > being more useful to the app.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
> > app/test/commands.c | 52 ------------
> > app/test/test_ring.c | 149 +--------------------------------
> > doc/guides/rel_notes/release_17_05.rst | 2 +
> > examples/Makefile | 2 +-
> > lib/librte_ring/rte_ring.c | 23 -----
> > lib/librte_ring/rte_ring.h | 58 +------------
> > 6 files changed, 8 insertions(+), 278 deletions(-)
>
> There are some other references to remove:
>
> app/test/autotest_test_funcs.py: child.sendline("set_watermark test 100")
> app/test/autotest_test_funcs.py: index = child.expect([" watermark=100",
> app/test/autotest_test_funcs.py: return -1, "Fail [Bad watermark]"
>
> doc/guides/prog_guide/ring_lib.rst:Water Marking
> doc/guides/prog_guide/ring_lib.rst:The ring can have a high water mark (threshold).
> doc/guides/prog_guide/ring_lib.rst:Once an enqueue operation reaches the high water mark, the producer is notified, if the water mark is configured.
>
Yep, good catch. Will include in v2
/Bruce
More information about the dev
mailing list