[dpdk-dev] [PATCH] vhost: change log levels in client mode
Maxime Coquelin
maxime.coquelin at redhat.com
Thu Mar 2 14:33:27 CET 2017
On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> Inability to connect to socket is a normal situation
> in client mode because, in common case, server isn't
> started yet. RTE_LOG_WARNING should be suitable for
> the case of some unusual errors.
> Message about reconnection is not an error at all.
>
> CC: stable at dpdk.org
> Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
>
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
> lib/librte_vhost/socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index aaa9c27..6a30a31 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return 0;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG,
> + RTE_LOG(WARNING, VHOST_CONFIG,
> "failed to connect to %s: %s\n",
> path, strerror(errno));
>
> @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return -1;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
> + RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
> reconn = malloc(sizeof(*reconn));
> if (reconn == NULL) {
> RTE_LOG(ERR, VHOST_CONFIG,
>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Thanks!
Maxime
More information about the dev
mailing list