[dpdk-dev] [PATCH] ppp implemantation

Bruce Richardson bruce.richardson at intel.com
Fri Mar 3 10:41:03 CET 2017


On Fri, Mar 03, 2017 at 09:39:26AM +0000, Bruce Richardson wrote:
> Given that this patch is not about point-to-point protocol, i.e. the
> best-known expansion of "PPP", I think you need to clarify the acronym
> in the commit message, at minimum, if not also in the commit title.
> 
> /Bruce
> 

Never mind, I see your updated patchset has already been sent with
better titles.

/Bruce
> On Fri, Mar 03, 2017 at 03:26:07PM +0800, Beilei Xing wrote:
> > Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> > ---
> >  app/test-pmd/cmdline.c                  |  57 ++++++++
> >  app/test-pmd/config.c                   |  62 +++++++++
> >  app/test-pmd/testpmd.h                  |   3 +
> >  drivers/net/i40e/base/i40e_adminq_cmd.h |  32 +++++
> >  drivers/net/i40e/base/i40e_common.c     | 236 +++++++++++++++++++++++++++++++-
> >  drivers/net/i40e/base/i40e_prototype.h  |  17 +++
> >  drivers/net/i40e/base/i40e_type.h       |  79 +++++++++++
> >  drivers/net/i40e/i40e_ethdev.c          |  68 +++++++++
> >  drivers/net/i40e/rte_pmd_i40e.h         |   1 +
> >  9 files changed, 554 insertions(+), 1 deletion(-)
> > 


More information about the dev mailing list