[dpdk-dev] [PATCH 8/9] net/ixgbe/base: fix build error

Ferruh Yigit ferruh.yigit at intel.com
Fri Mar 3 23:27:07 CET 2017


On 3/1/2017 6:04 AM, Wenzhuo Lu wrote:
> Fix ICC build error by removing the EWARN third parameter.

    Build error:
    .../drivers/net/ixgbe/base/ixgbe_phy.c(1543):
            error #268: the format string ends before this argument
                            EWARN(hw, "WARNING: Intel (R) Network "
                            ^

    .../drivers/net/ixgbe/base/ixgbe_phy.c(1805):
            error #268: the format string ends before this argument
                            EWARN(hw, "WARNING: Intel (R) Network "
                            ^

    Fixes: aa4fc14d2cee ("ixgbe: update base driver")
    Fixes: b94a06c1b451 ("ixgbe/base: support qsfp and lco")
    Cc: stable at dpdk.org

> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_phy.c | 23 ++---------------------
>  1 file changed, 2 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c
> index c953805..d2d06cf 100644
> --- a/drivers/net/ixgbe/base/ixgbe_phy.c
> +++ b/drivers/net/ixgbe/base/ixgbe_phy.c
> @@ -1540,16 +1540,7 @@ s32 ixgbe_identify_sfp_module_generic(struct ixgbe_hw *hw)
>  				status = IXGBE_SUCCESS;
>  			} else {
>  				if (hw->allow_unsupported_sfp == true) {
> -					EWARN(hw, "WARNING: Intel (R) Network "
> -					      "Connections are quality tested "
> -					      "using Intel (R) Ethernet Optics."
> -					      " Using untested modules is not "
> -					      "supported and may cause unstable"
> -					      " operation or damage to the "
> -					      "module or the adapter. Intel "
> -					      "Corporation is not responsible "
> -					      "for any harm caused by using "
> -					      "untested modules.\n", status);
> +					EWARN(hw, "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. Intel Corporation is not responsible for any harm caused by using untested modules.\n");

Although it has been agreed to not break log messages, this one is too long.
The reason to not break log message is to be able to search and find
message in the source code. Not required to have multi sentences in
single line, so log updated to break by sentences boundaries.

>  					status = IXGBE_SUCCESS;
>  				} else {
>  					DEBUGOUT("SFP+ module not supported\n");
> @@ -1802,16 +1793,7 @@ s32 ixgbe_identify_qsfp_module_generic(struct ixgbe_hw *hw)
>  				status = IXGBE_SUCCESS;
>  			} else {
>  				if (hw->allow_unsupported_sfp == true) {
> -					EWARN(hw, "WARNING: Intel (R) Network "
> -					      "Connections are quality tested "
> -					      "using Intel (R) Ethernet Optics."
> -					      " Using untested modules is not "
> -					      "supported and may cause unstable"
> -					      " operation or damage to the "
> -					      "module or the adapter. Intel "
> -					      "Corporation is not responsible "
> -					      "for any harm caused by using "
> -					      "untested modules.\n", status);
> +					EWARN(hw, "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. Intel Corporation is not responsible for any harm caused by using untested modules.\n");
>  					status = IXGBE_SUCCESS;
>  				} else {
>  					DEBUGOUT("QSFP module not supported\n");
> @@ -1836,7 +1818,6 @@ s32 ixgbe_identify_qsfp_module_generic(struct ixgbe_hw *hw)
>  	return IXGBE_ERR_SFP_NOT_PRESENT;
>  }
>  
> -
>  /**
>   *  ixgbe_get_sfp_init_sequence_offsets - Provides offset of PHY init sequence
>   *  @hw: pointer to hardware structure
> 



More information about the dev mailing list