[dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters

[Zhao1, Wei]

Hi, Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, February 18, 2017 12:01 AM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all
> filters
> 
> On 2/13/2017 7:35 AM, Wei Zhao wrote:
> > All kinds of filter need to hardware mac type check to make sure the
> > hardware support that type of fliter.
> > If not, it may cause serious issue.
> >
> > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter")
> > Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter")
> > Fixes: 429f6ebb42cc ("net/ixgbe: parse TCP SYN filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_flow.c | 129
> > +++++++++++++++++++++--------------------
> >  1 file changed, 65 insertions(+), 64 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 5a634d3..f414fa8 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -84,11 +84,12 @@ cons_parse_ntuple_filter(const struct rte_flow_attr
> *attr,
> >  					struct rte_eth_ntuple_filter *filter,
> >  					struct rte_flow_error *error);
> >  static int
> > -ixgbe_parse_ntuple_filter(const struct rte_flow_attr *attr,
> > -					const struct rte_flow_item pattern[],
> > -					const struct rte_flow_action actions[],
> > -					struct rte_eth_ntuple_filter *filter,
> > -					struct rte_flow_error *error);
> > +ixgbe_parse_ntuple_filter(struct rte_eth_dev *dev,
> > +			  const struct rte_flow_attr *attr,
> > +			  const struct rte_flow_item pattern[],
> > +			  const struct rte_flow_action actions[],
> > +			  struct rte_eth_ntuple_filter *filter,
> > +			  struct rte_flow_error *error);
> 
> Hi Wei,
> 
> You don't need these function declarations at all. What do you think
> removing these first, in a separate patch, and won't need to update them
> here?
> 
> Also it is possible to remove all function declarations if you move
> "ixgbe_flow_ops" at the end of the file, that would be something I prefer,
> but it is your call.
> 
> Thanks,
> Ferruh

Sorry for late reply, I have just find your mail just now.
 I think your suggestion is very good from code style, but this patch is a fix patch set for a P2 issue.
So, it is not focus on code style. code style can be changed in
a separate patch if we need to and not mix them together?