[dpdk-dev] [PATCH 1/4] ethdev: add retrieving xstats by group and xstats by name
Thomas Monjalon
thomas.monjalon at 6wind.com
Mon Mar 6 11:17:54 CET 2017
Hi,
2017-03-03 13:54, Kuba Kozak:
> From: Jacek Piasecki <jacekx.piasecki at intel.com>
>
> This patch extends library for retriving xstats by specified groups and
> single xstat by given name.
>
> Signed-off-by: Jacek Piasecki <jacekx.piasecki at intel.com>
> Signed-off-by: Kuba Kozak <kubax.kozak at intel.com>
As you probably know, it is difficult to have a good review
(or a simple review at all).
The most difficult part in such a change is not writing the code,
it is explaining your idea and getting people to agree.
Please show you have thought about the API, seen an issue or a lack,
and propose an idea with a clear target.
In short, we are missing a "why" and "how".
You must also explain what is a group, better than a list of #define.
More information about the dev
mailing list