[dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag

Mody, Rasesh Rasesh.Mody at cavium.com
Mon Mar 6 21:02:47 CET 2017


> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Thursday, March 02, 2017 5:04 AM
> 
> On 2/27/2017 7:51 AM, Rasesh Mody wrote:
> > dcbx-update-flag is incorrectly converted to boolean before assigining
> > it to ramrod data, fix this typecasting. Also, added more debug
> > messages in the dcbx code paths.
> >
> > Fixes: 26ae839d06e9 ("qede: add DCBX support")
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody at cavium.com>
> > ---
> <...>
> 
> Not to this patch, but for the whole patchset, thank you for splitting fixes into
> small chunks, this makes review easier.
> 
> And for patches you want them in stable tree, please
> - CC those patches to stable mail list (stable at dpdk.org)
> - and add a new tag in commit log just below "Fixes: " line, like:

Thanks for the feedback. We'll address this and rest of the feedback on this patch set in v2 series submission.

> 
> "
> 
> Fixes: xxxxxxxxxxxx ("...")
> Cc: stable at dpdk.org
> 
> Signed-off-by: ....
> Acked-by: ....
> "



More information about the dev mailing list