[dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

Adrien Mazarguil adrien.mazarguil at 6wind.com
Mon Mar 20 14:56:58 CET 2017


Hi Ferruh,

On Mon, Mar 20, 2017 at 01:24:36PM +0000, Ferruh Yigit wrote:
> On 3/16/2017 11:04 AM, Adrien Mazarguil wrote:
> > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote:
> >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus
> >> address.
> >>
> >> Add a new port parameter allowing the user to choose
> >> either or both physical ports to be used by the application.
> >>
> >> This parameter is used as follows:
> >>
> >> Selecting only the second port:
> >>    -w 00:00.0,port=1
> >>
> >> Selecting both ports:
> >>    -w 00:00.0,port=0,port=1
> >>
> >> If no parameter is given, the default behavior is unchanged: all ports
> >> are probed.
> >>
> >> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> > 
> > I think this patch is good as is. Whatever value results from users
> > specifying random characters as argument to the port parameter is their
> > problem, as long as the resulting value is verified to be within bounds,
> > it's fine.
> > 
> > I'm not saying that checking all possible failure modes of strtoul() is
> > useless, just that it seems overkill in this specific case. Using atoi()
> > without any error checking would have been perfectly fine as well.
> > 
> > Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
> 
> Hi Adrien, Gaetan,
> 
> Are all comments addressed for this patch? It looks like discussion is
> going on?

I think it's over, no more comments will follow.

-- 
Adrien Mazarguil
6WIND


More information about the dev mailing list