[dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header

Pascal Mazon pascal.mazon at 6wind.com
Tue Mar 21 17:57:52 CET 2017


On Tue, 21 Mar 2017 15:32:06 +0000
"Wiles, Keith" <keith.wiles at intel.com> wrote:

> 
> Just noticed this new header does not have the C++ ifdefs. Create a
> new patch to fix this problem, unless you need to update this patch
> series. Just starting my review of this one, sorry was traveling last
> week.
> 
> Regards,
> Keith
> 

Hi Keith,

rte_eth_tap.h header is only presenting functions for local use within
the tap driver. That part of the code is completely internal to the
driver, compiled as pure C, and is not to be used directly by the
(potentially c++) user application linking itself with DPDK.

It's thus normal to keep it standard C without the need for c++ ifdefs.

The other PMDs in drivers/net also don't use the c++ ifdefs in their
headers, by the way.

Best regards,
Pascal


More information about the dev mailing list