[dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields

[Bruce Richardson]

On Mon, Mar 27, 2017 at 03:13:04PM +0200, Thomas Monjalon wrote:
> 2017-03-27 11:15, Bruce Richardson:
> > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote:
> > > 2017-03-24 17:09, Bruce Richardson:
> > > > The size and mask fields are duplicated in both the producer and
> > > > consumer data structures. Move them out of that into the top level
> > > > structure so they are not duplicated.
> > > > 
> > > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > > > Acked-by: Olivier Matz <olivier.matz at 6wind.com>
> > > 
> > > Sorry Bruce, I encounter this error:
> > > 
> > > fatal error: no member named 'size' in 'struct rte_ring_headtail'
> > >                 if (r->prod.size >= ring_size) {
> > >                     ~~~~~~~ ^
> > > 
> > Ok, I think I've found it now using git grep. I assume this is in the
> > crypto code which is disabled by default, right?
> 
> Right, sorry for forgetting the context.

Submitted a new patch for the crypto drivers to fix this issue. The
previous patch I did to fix this as a pre-requisite didn't catch the
drivers that were disabled by default.

http://dpdk.org/dev/patchwork/patch/22445/

I've verified this now compiles with the aesni-mb crypto PMD enabled at
least. I'll see about enabling a few more crypto drivers on my system
just in case there are other things I missed in them for this set.

/Bruce