[dpdk-dev] [PATCH v8 2/6] net/i40e: add dynamic device personalization processing

[Ferruh Yigit]

On 3/30/2017 3:51 AM, Beilei Xing wrote:
> Add support for loading a dynamic device personalization
> profile.
> 
> Signed-off-by: Beilei Xing <beilei.xing at intel.com>

<...>

> diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
> index 3ca49a4..94dd92e 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -65,6 +65,43 @@ struct rte_pmd_i40e_mb_event_param {
>  	uint16_t msglen;   /**< length of the message */
>  };
>  
> +enum rte_pmd_i40e_package_op {

This is generating a doxygen warning [1], can you please address this in
a separate patch?

Meanwhile some of the bellowing doxygen comments are not very detailed.
Please feel free to update them at will in patch.

Thanks,
ferruh

[1]
net/i40e/rte_pmd_i40e.h:68: warning: Member rte_pmd_i40e_package_op
(enumeration) of file rte_pmd_i40e.h is not documented.

> +	RTE_PMD_I40E_PKG_OP_UNDEFINED = 0,
> +	RTE_PMD_I40E_PKG_OP_WR_ADD,   /**< load package and add to info list */
> +	RTE_PMD_I40E_PKG_OP_MAX = 32
> +};
> +
> +#define RTE_PMD_I40E_DDP_NAME_SIZE 32
> +
> +/**
> + * Dynamic device personalization version
> + */
> +struct rte_pmd_i40e_ddp_version {
> +	uint8_t major;
> +	uint8_t minor;
> +	uint8_t update;
> +	uint8_t draft;
> +};
> +
> +/**
> + * Structure of profile information
> + */
> +struct rte_pmd_i40e_profile_info {
> +	uint32_t track_id;
> +	struct rte_pmd_i40e_ddp_version version;
> +	uint8_t owner;
> +	uint8_t reserved[7];
> +	uint8_t name[RTE_PMD_I40E_DDP_NAME_SIZE];
> +};
> +
> +/**
> + * Structure of profile information list
> + */
> +struct rte_pmd_i40e_profile_list {
> +	uint32_t p_count;
> +	struct rte_pmd_i40e_profile_info p_info[1];
> +};

<...>