[dpdk-dev] [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 29, 2017 2:04 PM
> To: dev at dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K;
> Kusztal, ArkadiuszX
> Subject: [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure
> 
> Refactor capabilities data structures to facilitate
> defining different capability sets for different devices
> without duplication of data.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
> ---
>  drivers/crypto/qat/qat_crypto.c              | 532 ++-------------------------
>  drivers/crypto/qat/qat_crypto.h              |   3 +
>  drivers/crypto/qat/qat_crypto_capabilities.h | 510
> +++++++++++++++++++++++++
>  drivers/crypto/qat/rte_qat_cryptodev.c       |  24 ++
>  4 files changed, 577 insertions(+), 492 deletions(-)
>  create mode 100644 drivers/crypto/qat/qat_crypto_capabilities.h
> 
> diff --git a/drivers/crypto/qat/qat_crypto.c
> b/drivers/crypto/qat/qat_crypto.c
> index 9310211..9678a70 100644
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -69,497 +69,45 @@
> 
>  #define BYTE_LENGTH    8
> 
> -static const struct rte_cryptodev_capabilities qat_pmd_capabilities[] = {
> -	{	/* SHA1 HMAC */
> -		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> -		{.sym = {
> -			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> -			{.auth = {
> -				.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
> -				.block_size = 64,
> -				.key_size = {
> -					.min = 64,
> -					.max = 64,
> -					.increment = 0
> -				},
> -				.digest_size = {
> -					.min = 20,
> -					.max = 20,
> -					.increment = 0
> -				},
> -				.aad_size = { 0 }
> -			}, }
> -		}, }
> -	},
> -	{	/* SHA224 HMAC */
> -		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> -		{.sym = {
> -			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> -			{.auth = {
> -				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> -				.block_size = 64,
> -					.key_size = {

Remove one tab before .key_size, to be aligned with the other fields.

Thanks,
Pablo