[dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times
Michael Lilja
ml at napatech.com
Wed May 17 17:33:35 CEST 2017
Please fix while applying.
-----Original Message-----
From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
Sent: 17 May 2017 17:17
To: Michael Lilja <ml at napatech.com>; helin.zhang at intel.com; jingjing.wu at intel.com
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times
On 5/17/2017 3:57 PM, Michael Lilja wrote:
> Previously, the FDIR programming time is +11ms on i40e.
> This patch will result in an average programming time of 22usec with a
> max of 60usec .
>
> Signed-off-by: Michael Lilja <ml at napatech.com>
<...>
> /* totally delay 10 ms to check programming status*/
> - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_US);
> - if (i40e_check_fdir_programming_status(rxq) < 0) {
> - PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
> - " programming status reported.");
> - return -ENOSYS;
> + for (; i < I40E_FDIR_MAX_WAIT_US; i++) {
> + if (i40e_check_fdir_programming_status(rxq) >= 0)
> + return 0;
> + rte_delay_us(1);
> }
> -
> - return 0;
> + PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
> + " programming status reported."
I am aware that you just moved this log, but since you have touched to it, can you please fix it too [1]:
PMD_DRV_LOG(ERR,
"Failed to program FDIR filter: programming status reported.");
[1] Or if you prefer please let me know, so I can fix it while applying.
> + return -ETIMEDOUT;
> }
>
> /*
>
More information about the dev
mailing list