[dpdk-dev] [PATCH] vhost: support rx_queue_count

[Yuanhan Liu]

On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote:
> 
> 
> > -----Original Message-----
> > From: Jens Freimann [mailto:jfreiman at redhat.com]
> > Sent: Tuesday, May 23, 2017 7:54 PM
> > To: Wang, Zhihong <zhihong.wang at intel.com>
> > Cc: dev at dpdk.org; yuanhan.liu at linux.intel.com
> > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
> > 
> > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote:
> > > This patch implements the ops rx_queue_count for vhost PMD by adding
> > > a helper function rte_vhost_rx_queue_count in vhost lib.
> > >
> > > The ops ops rx_queue_count gets vhost RX queue avail count and helps
> > 
> > s/ops ops/ops/ ?
> 
> Thanks a lot!

Seems you overlooked other comments, such as:

> > > +	vq = dev->virtqueue[qid];
> > 
> > check for vq == NULL?
> > 
> > regards,
> > Jens

Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept
both :)

	--yliu