[dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

[Ajit Khaparde]

On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit <ferruh.yigit at intel.com>
wrote:

> > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
> > +{
> > +     struct rte_eth_dev *dev;
> > +     struct rte_eth_dev_info dev_info;
> > +     struct bnxt *bp;
> > +
> > +     dev = &rte_eth_devices[port];
> > +     rte_eth_dev_info_get(port, &dev_info);
> > +     bp = (struct bnxt *)dev->data->dev_private;
> > +
> > +     return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
> > +}
>
> This function is not to get VF stats from PF. As far as I can see this
> just gets queue stats, does this really needs to be PMD specific API,
> isn't this something generic?


​Yes. That is right. It returns a count of number of packets which were not
transmitted
because it did not pass the MAC/VLAN spoof check. It does not necessarily
mean "failure to transmit" and so I don't think it is right to map it to
oerrors.
So in the current form I don't see a way to make a generic function out of
it.​