[dpdk-dev] [PATCH] net/mrvl: reset errno before library call

Tomasz Duszynski tdu at semihalf.com
Thu Nov 2 09:37:25 CET 2017


In case errno contains some non-zero value and call to strtoul() is
successful -2 error will be returned.

Setting errno to zero before calling strtoul() makes sure
errors will be handled correctly.

Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton")

Signed-off-by: Tomasz Duszynski <tdu at semihalf.com>
---
 drivers/net/mrvl/mrvl_qos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mrvl/mrvl_qos.c b/drivers/net/mrvl/mrvl_qos.c
index 55f6406..2076228 100644
--- a/drivers/net/mrvl/mrvl_qos.c
+++ b/drivers/net/mrvl/mrvl_qos.c
@@ -122,6 +122,7 @@ get_val_securely(const char *string, uint32_t *val)
 	if (len == 0)
 		return -1;

+	errno = 0;
 	*val = strtoul(string, &endptr, 0);
 	if (errno != 0 || RTE_PTR_DIFF(endptr, string) != len)
 		return -2;
--
2.7.4



More information about the dev mailing list