[dpdk-dev] [PATCH v4 11/15] mbuf: rename physical address to IOVA

[Thomas Monjalon]

06/11/2017 16:52, Olivier MATZ:
> On Mon, Nov 06, 2017 at 02:41:37AM +0100, Thomas Monjalon wrote:
> > From: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> > 
> > Rename buf_physaddr to buf_iova.
> > Keep the deprecated name in an anonymous union to avoid breaking
> > the API.
> > 
> > Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> > Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> 
> Just be aware that I still see some references to ->buf_physaddr.
> 
> $ git grep buf_physaddr
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op->sym->aead.digest.phys_addr = mbuf->buf_physaddr;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = (uint64_t)op;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    op = (struct rte_crypto_op *)mbuf->buf_physaddr;
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:    mbuf->buf_physaddr = op->sym->aead.digest.phys_addr;
> drivers/crypto/dpaa_sec/dpaa_sec.c:     src_start_addr = sym->m_src->buf_physaddr + sym->m_src->data_off;
> drivers/crypto/dpaa_sec/dpaa_sec.c:             dst_start_addr = sym->m_dst->buf_physaddr + sym->m_dst->data_off;
> lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:  uint64_t buf_physaddr;
> lib/librte_eal/linuxapp/kni/kni_net.c:                  (unsigned long)m->buf_physaddr);
> lib/librte_eal/linuxapp/kni/kni_net.c:  return phys_to_virt(m->buf_physaddr + m->data_off);
> lib/librte_eal/linuxapp/kni/kni_net.c:                   (unsigned long)m->buf_physaddr));
> lib/librte_mbuf/rte_mbuf.h:             rte_iova_t buf_physaddr; /**< deprecated */

Yes, it is on purpose.
KNI is known to work only with physical addresses for now.
I am not sure about NXP buses, but I had the feeling that it deserves a
separate work.