[dpdk-dev] [PATCH] config: sort PMD config options

Aleksey Baulin Aleksey.Baulin at gmail.com
Wed Nov 22 00:17:50 CET 2017
Previous message: [dpdk-dev] [PATCH] config: sort PMD config options
Next message: [dpdk-dev] [PATCH] config: sort PMD config options
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Ferruh,

Not that it really mattered much, but I couldn't help but notice several
irregularities in the order of options that could have been avoided.
In particular, I believe it would make sense to put all xxx_DEBUG_xxx
options after the real control options, thus making it two classes of
options within each group.

In the end, I think the regular order of options will be broken sooner
or later anyway, as it's something that's highly difficult to enforce.
Not everyone has the same feel of the "correct" order.

Please see the comments below in the middle of the patch.

Thanks,
Aleksey.


On Wed, Nov 22, 2017 at 1:39 AM, Ferruh Yigit <ferruh.yigit at intel.com>
wrote:

> No config option changed, added or removed.
> Only reshuffle PMD config options mostly to help new PMDs where to put
> their new config option.
>
> Ordered as physical, paravirtual and virtual groups. Alphabetical order
> within a group.
>
> Also tried to group vendor devices together which breaks alphabetical
> order in some places.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
>  config/common_base | 214 ++++++++++++++++++++++++++----
> -----------------------
>  1 file changed, 107 insertions(+), 107 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index e74febef4..57a346e30 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -163,6 +163,69 @@ CONFIG_RTE_LIBRTE_PCI_BUS=y
>  CONFIG_RTE_LIBRTE_VDEV_BUS=y
>
>  #
> +# Compile ARK PMD
> +#
> +CONFIG_RTE_LIBRTE_ARK_PMD=y
> +CONFIG_RTE_LIBRTE_ARK_PAD_TX=y
> +CONFIG_RTE_LIBRTE_ARK_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_ARK_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS=n
> +CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=n
> +
> +#
> +# Compile burst-oriented Broadcom PMD driver
> +#
> +CONFIG_RTE_LIBRTE_BNX2X_PMD=n
> +CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n
> +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=n
> +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=n
>

I would move this option up after the first one (PMD).

+CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n
> +
> +#
> +# Compile burst-oriented Broadcom BNXT PMD driver
> +#
> +CONFIG_RTE_LIBRTE_BNXT_PMD=y
> +
> +#
> +# Compile burst-oriented Chelsio Terminator (CXGBE) PMD
> +#
> +CONFIG_RTE_LIBRTE_CXGBE_PMD=y
> +CONFIG_RTE_LIBRTE_CXGBE_DEBUG=n
> +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=n
> +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=n
> +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_CXGBE_TPUT=y
>

I would move this option up after the first one (PMD).


> +
> +# NXP DPAA Bus
> +CONFIG_RTE_LIBRTE_DPAA_BUS=n
> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n
> +CONFIG_RTE_LIBRTE_DPAA_PMD=n
>

I would place this option first in this group, for the sake
of uniformity. Everywhere else a similar option comes first.


> +
> +#
> +# Compile NXP DPAA2 FSL-MC Bus
> +#
> +CONFIG_RTE_LIBRTE_FSLMC_BUS=n
> +
> +#
> +# Compile Support Libraries for NXP DPAA2
> +#
> +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n
> +CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
> +
> +#
> +# Compile burst-oriented NXP DPAA2 PMD driver
> +#
> +CONFIG_RTE_LIBRTE_DPAA2_PMD=n
> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n
> +
> +#
>  # Compile burst-oriented Amazon ENA PMD driver
>  #
>  CONFIG_RTE_LIBRTE_ENA_PMD=y
> @@ -173,6 +236,13 @@ CONFIG_RTE_LIBRTE_ENA_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n
>
>  #
> +# Compile burst-oriented Cisco ENIC PMD driver
> +#
> +CONFIG_RTE_LIBRTE_ENIC_PMD=y
> +CONFIG_RTE_LIBRTE_ENIC_DEBUG=n
> +CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW=n
> +
> +#
>  # Compile burst-oriented IGB & EM PMD drivers
>  #
>  CONFIG_RTE_LIBRTE_EM_PMD=y
> @@ -241,49 +311,23 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
>  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
>
>  #
> -# Compile burst-oriented Broadcom PMD driver
> -#
> -CONFIG_RTE_LIBRTE_BNX2X_PMD=n
> -CONFIG_RTE_LIBRTE_BNX2X_DEBUG=n
> -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=n
> -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=n
> -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n
> -
> -#
> -# Compile burst-oriented Chelsio Terminator (CXGBE) PMD
> -#
> -CONFIG_RTE_LIBRTE_CXGBE_PMD=y
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_CXGBE_TPUT=y
> -
> -#
> -# Compile burst-oriented Cisco ENIC PMD driver
> -#
> -CONFIG_RTE_LIBRTE_ENIC_PMD=y
> -CONFIG_RTE_LIBRTE_ENIC_DEBUG=n
> -CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW=n
> -
> -#
>  # Compile burst-oriented Netronome NFP PMD driver
>  #
>  CONFIG_RTE_LIBRTE_NFP_PMD=n
>  CONFIG_RTE_LIBRTE_NFP_DEBUG=n
>
> +# QLogic 10G/25G/40G/50G/100G PMD
>  #
> -# Compile Marvell PMD driver
> -#
> -CONFIG_RTE_LIBRTE_MRVL_PMD=n
> -
> -#
> -# Compile burst-oriented Broadcom BNXT PMD driver
> -#
> -CONFIG_RTE_LIBRTE_BNXT_PMD=y
> +CONFIG_RTE_LIBRTE_QEDE_PMD=y
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=y
>

I would move this option up after the first one (PMD).
Not sure about the option below. Given a lengthy comment
to it, perhaps it's best if it stays there. But then, perhaps not.


> +#Provides abs path/name of the firmware file.
> +#Empty string denotes driver will use default firmware
> +CONFIG_RTE_LIBRTE_QEDE_FW=""
>
>  #
>  # Compile burst-oriented Solarflare libefx-based PMD
> @@ -292,11 +336,6 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y
>  CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n
>
>  #
> -# Compile SOFTNIC PMD
> -#
> -CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y
> -
> -#
>  # Compile software PMD backed by SZEDATA2 device
>  #
>  CONFIG_RTE_LIBRTE_PMD_SZEDATA2=n
> @@ -327,11 +366,6 @@ CONFIG_RTE_LIBRTE_LIO_DEBUG_TX=n
>  CONFIG_RTE_LIBRTE_LIO_DEBUG_MBOX=n
>  CONFIG_RTE_LIBRTE_LIO_DEBUG_REGS=n
>
> -# NXP DPAA Bus
> -CONFIG_RTE_LIBRTE_DPAA_BUS=n
> -CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n
> -CONFIG_RTE_LIBRTE_DPAA_PMD=n
> -
>  #
>  # Compile burst-oriented Cavium OCTEONTX network PMD driver
>  #
> @@ -343,25 +377,13 @@ CONFIG_RTE_LIBRTE_OCTEONTX_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_OCTEONTX_DEBUG_MBOX=n
>
>  #
> -# Compile NXP DPAA2 FSL-MC Bus
> -#
> -CONFIG_RTE_LIBRTE_FSLMC_BUS=n
> -
> -#
> -# Compile Support Libraries for NXP DPAA2
> -#
> -CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n
> -CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
> -
> -#
> -# Compile burst-oriented NXP DPAA2 PMD driver
> +# Compile WRS accelerated virtual port (AVP) guest PMD driver
>  #
> -CONFIG_RTE_LIBRTE_DPAA2_PMD=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n
> +CONFIG_RTE_LIBRTE_AVP_PMD=n
> +CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
> +CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
>
>  #
>  # Compile burst-oriented VIRTIO PMD driver
> @@ -389,16 +411,9 @@ CONFIG_RTE_LIBRTE_VMXNET3_DEBUG_TX_FREE=n
>  CONFIG_RTE_LIBRTE_VMXNET3_DEBUG_DRIVER=n
>
>  #
> -# Compile example software rings based PMD
> -#
> -CONFIG_RTE_LIBRTE_PMD_RING=y
> -CONFIG_RTE_PMD_RING_MAX_RX_RINGS=16
> -CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16
> -
> -#
> -# Compile software PMD backed by PCAP files
> +# Compile software PMD backed by AF_PACKET sockets (Linux only)
>  #
> -CONFIG_RTE_LIBRTE_PMD_PCAP=n
> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=n
>
>  #
>  # Compile link bonding PMD library
> @@ -407,58 +422,43 @@ CONFIG_RTE_LIBRTE_PMD_BOND=y
>  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB=n
>  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
>
> -# QLogic 10G/25G/40G/50G/100G PMD
>  #
> -CONFIG_RTE_LIBRTE_QEDE_PMD=y
> -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
> -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
> -CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n
> -CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=y
> -#Provides abs path/name of the firmware file.
> -#Empty string denotes driver will use default firmware
> -CONFIG_RTE_LIBRTE_QEDE_FW=""
> +# Compile fail-safe PMD
> +#
> +CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y
>
>  #
> -# Compile software PMD backed by AF_PACKET sockets (Linux only)
> +# Compile Marvell PMD driver
>  #
> -CONFIG_RTE_LIBRTE_PMD_AF_PACKET=n
> +CONFIG_RTE_LIBRTE_MRVL_PMD=n
>
>  #
> -# Compile ARK PMD
> +# Compile null PMD
>  #
> -CONFIG_RTE_LIBRTE_ARK_PMD=y
> -CONFIG_RTE_LIBRTE_ARK_PAD_TX=y
> -CONFIG_RTE_LIBRTE_ARK_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_ARK_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS=n
> -CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=n
> +CONFIG_RTE_LIBRTE_PMD_NULL=y
>
>  #
> -# Compile WRS accelerated virtual port (AVP) guest PMD driver
> +# Compile software PMD backed by PCAP files
>  #
> -CONFIG_RTE_LIBRTE_AVP_PMD=n
> -CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=n
> -CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
> -CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
> +CONFIG_RTE_LIBRTE_PMD_PCAP=n
>
>  #
> -# Compile the TAP PMD
> -# It is enabled by default for Linux only.
> +# Compile example software rings based PMD
>  #
> -CONFIG_RTE_LIBRTE_PMD_TAP=n
> +CONFIG_RTE_LIBRTE_PMD_RING=y
> +CONFIG_RTE_PMD_RING_MAX_RX_RINGS=16
> +CONFIG_RTE_PMD_RING_MAX_TX_RINGS=16
>
>  #
> -# Compile null PMD
> +# Compile SOFTNIC PMD
>  #
> -CONFIG_RTE_LIBRTE_PMD_NULL=y
> +CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y
>
>  #
> -# Compile fail-safe PMD
> +# Compile the TAP PMD
> +# It is enabled by default for Linux only.
>  #
> -CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y
> +CONFIG_RTE_LIBRTE_PMD_TAP=n
>
>  #
>  # Do prefetch of packet data within PMD driver receive function
> --
> 2.13.6
>
>
-- 
Aleksey Baulin
Previous message: [dpdk-dev] [PATCH] config: sort PMD config options
Next message: [dpdk-dev] [PATCH] config: sort PMD config options
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the dev mailing list