[dpdk-dev] [RFC 8/9] net/avf: enable ops to check queue info and status

Wu, Jingjing jingjing.wu at intel.com
Wed Nov 22 09:23:57 CET 2017



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, November 22, 2017 8:09 AM
> To: Wu, Jingjing <jingjing.wu at intel.com>; dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Olivier MATZ
> <olivier.matz at 6wind.com>
> Subject: Re: [dpdk-dev] [RFC 8/9] net/avf: enable ops to check queue info and
> status
> 
> On 10/20/2017 1:26 AM, Jingjing Wu wrote:
> >  - rxq_info_get
> >  - txq_info_get
> >  - rx_queue_count
> >  - rx_descriptor_done
> >  - rx_descriptor_status
> >  - tx_descriptor_status
> 
> + some documentation.
> 
> <...>
> 
> > @@ -28,8 +28,8 @@
> >      (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
> >      OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> >
> > -I40E/IXGBE/IGB Virtual Function Driver
> 
> AVF doesn't cover ixgbe/igb virtual functions right? Perhaps it can be good to
> keep information for them.
> 
Just rename "I40E/IXGBE/IGB Virtual Function Driver" to be " Intel Virtual Function Driver" which doesn't indicate AVF.

And i40e, ixgbe, igb NICs are described below in this doc.

> <...>
> 
> > @@ -132,7 +132,15 @@ static const struct eth_dev_ops avf_eth_dev_ops = {
> >  	.reta_query                 = avf_dev_rss_reta_query,
> >  	.rss_hash_update            = avf_dev_rss_hash_update,
> >  	.rss_hash_conf_get          = avf_dev_rss_hash_conf_get,
> > +	.rxq_info_get               = avf_dev_rxq_info_get,
> > +	.txq_info_get               = avf_dev_txq_info_get,
> > +	.rx_queue_count             = avf_dev_rxq_count,
> > +	.rx_descriptor_done         = avf_dev_rx_desc_done,
> 
> If you implemented "rx_descriptor_status" no need to implement
> "rx_descriptor_done", one covers other.
> 

Thanks, will change.

> cc'ed Olivier if I am missing anything.
> 
> <...>


More information about the dev mailing list