[dpdk-dev] [dpdk-stable] [PATCH 15/53] net/sfc/base: fix PreFAST issues
Andrew Rybchenko
arybchenko at solarflare.com
Tue Nov 28 12:49:04 CET 2017
On 11/27/2017 10:58 PM, Ferruh Yigit wrote:
> On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
>> From: Andy Moreton <amoreton at solarflare.com>
>>
> PREfast seems a static analysis tool. Can you please give more detail about
> fixed issue itself. "fix PREfast issue" is not informative about what has been
> fixed.
>
> If you can send the details I can amend the commit.
Add missing annotation that function return value should not be
ignored. Fix alignment.
Thanks,
Andrew.
>
> Thanks,
> ferruh
>
>> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Andy Moreton <amoreton at solarflare.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
>> ---
>> drivers/net/sfc/base/efx.h | 12 ++++++------
>> drivers/net/sfc/base/efx_phy.c | 2 +-
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
>> index 834eea0..ca0f945 100644
>> --- a/drivers/net/sfc/base/efx.h
>> +++ b/drivers/net/sfc/base/efx.h
>> @@ -913,13 +913,13 @@ efx_phy_media_type_get(
>> __in efx_nic_t *enp,
>> __out efx_phy_media_type_t *typep);
>>
>> -extern efx_rc_t
>> +extern __checkReturn efx_rc_t
>> efx_phy_module_get_info(
>> - __in efx_nic_t *enp,
>> - __in uint8_t dev_addr,
>> - __in uint8_t offset,
>> - __in uint8_t len,
>> - __out_bcount(len) uint8_t *data);
>> + __in efx_nic_t *enp,
>> + __in uint8_t dev_addr,
>> + __in uint8_t offset,
>> + __in uint8_t len,
>> + __out_bcount(len) uint8_t *data);
>>
>> #if EFSYS_OPT_PHY_STATS
>>
>> diff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c
>> index 752cd52..c81a91c 100644
>> --- a/drivers/net/sfc/base/efx_phy.c
>> +++ b/drivers/net/sfc/base/efx_phy.c
>> @@ -296,7 +296,7 @@ efx_phy_media_type_get(
>> *typep = epp->ep_fixed_port_type;
>> }
>>
>> - __checkReturn efx_rc_t
>> + __checkReturn efx_rc_t
>> efx_phy_module_get_info(
>> __in efx_nic_t *enp,
>> __in uint8_t dev_addr,
>>
More information about the dev
mailing list