[dpdk-dev] [PATCH] acl: fix unchecked return value

[Kozak, KubaX]

Thanks Konstantin,

I'll fix subject name and resend patch to dpdk witch Your ACK.

>-----Original Message-----
>From: Ananyev, Konstantin
>Sent: Monday, October 2, 2017 16:22
>To: Kozak, KubaX <kubax.kozak at intel.com>
>Cc: dev at dpdk.org; stable at dpdk.org
>Subject: RE: [PATCH] acl: fix unchecked return value
>
>
>
>> -----Original Message-----
>> From: Kozak, KubaX
>> Sent: Wednesday, September 20, 2017 11:02 AM
>> To: Ananyev, Konstantin <konstantin.ananyev at intel.com>
>> Cc: dev at dpdk.org; Kozak, KubaX <kubax.kozak at intel.com>;
>> stable at dpdk.org
>> Subject: [PATCH] acl: fix unchecked return value
>>
>> Add return value check and error handling for fseek call.
>>
>> Coverity issue: 143435
>> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
>> Cc: konstantin.ananyev at intel.com
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Kuba Kozak <kubax.kozak at intel.com>
>> ---
>>  examples/l3fwd-acl/main.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
>> index 8eff4de..708e9eb 100644
>> --- a/examples/l3fwd-acl/main.c
>> +++ b/examples/l3fwd-acl/main.c
>> @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
>>  	char buff[LINE_MAX];
>>  	FILE *fh = fopen(rule_path, "rb");
>>  	unsigned int i = 0;
>> +	int val;
>>
>>  	if (fh == NULL)
>>  		rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, @@ -1042,7
>> +1043,11 @@ add_rules(const char *rule_path,
>>  		rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
>>  				rule_path);
>>
>> -	fseek(fh, 0, SEEK_SET);
>> +	val = fseek(fh, 0, SEEK_SET);
>> +	if (val < 0) {
>> +		rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
>> +			__func__);
>> +	}
>>
>>  	acl_rules = calloc(acl_num, rule_size);
>>
>> --
>> 2.7.4
>
>Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
>
>BTW, I think it should be l3fwd-acl inside the subject line.