[dpdk-dev] [PATCH v6 4/6] gso: add GRE GSO support

[Kavanagh, Mark B]

>-----Original Message-----
>From: Ananyev, Konstantin
>Sent: Wednesday, October 4, 2017 3:16 PM
>To: Kavanagh, Mark B <mark.b.kavanagh at intel.com>; dev at dpdk.org
>Cc: Hu, Jiayu <jiayu.hu at intel.com>; Tan, Jianfeng <jianfeng.tan at intel.com>;
>Yigit, Ferruh <ferruh.yigit at intel.com>; thomas at monjalon.net
>Subject: RE: [PATCH v6 4/6] gso: add GRE GSO support
>
>
>> diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c
>> index 6095689..b748ab1 100644
>> --- a/lib/librte_gso/rte_gso.c
>> +++ b/lib/librte_gso/rte_gso.c
>> @@ -60,8 +60,9 @@
>>
>>  	if ((gso_ctx->gso_size >= pkt->pkt_len) || (gso_ctx->gso_types &
>>  				(DEV_TX_OFFLOAD_TCP_TSO |
>> -				 DEV_TX_OFFLOAD_VXLAN_TNL_TSO)) !=
>> -				gso_ctx->gso_types) {
>> +				 DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
>> +				 DEV_TX_OFFLOAD_GRE_TNL_TSO)) !=
>> +				 gso_ctx->gso_types) {
>>  		pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>>  		pkts_out[0] = pkt;
>>  		return 1;
>> @@ -73,7 +74,8 @@
>>  	ipid_delta = (gso_ctx->ipid_flag != RTE_GSO_IPID_FIXED);
>>  	ol_flags = pkt->ol_flags;
>>
>> -	if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags)) {
>> +	if (IS_IPV4_VXLAN_TCP4(pkt->ol_flags) ||
>> +			IS_IPV4_GRE_TCP4(pkt->ol_flags)) {
>
>Same comment as for previous patch: user might want that ctx to
>Segment vxlan packets and not segment gro packets.
>Konstantin

Thanks Konstantin - I'll update appropriately.

>
>>  		pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>>  		ret = gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta,
>>  				direct_pool, indirect_pool,
>> --
>> 1.9.3