[dpdk-dev] [PATCH v5] devtools: rework abi checker script

Neil Horman nhorman at tuxdriver.com
Thu Oct 5 15:15:43 CEST 2017


On Thu, Oct 05, 2017 at 09:53:27AM +0200, Olivier Matz wrote:
> The initial version of the script had some limitations:
> - cannot work on a non-clean workspace
> - environment variables are not documented
> - no compilation log in case of failure
> - return success even it abi is incompatible
> 
> This patch addresses these issues and rework the code.
> 
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> Acked-by: Neil Horman <nhorman at tuxdriver.com>
> ---
> 
> v4->v5:
> - Add a log when shared lib has no public ABI
> 
> v3->v4:
> - clarify logs on incompatible abi
> - log when an error returned an error
> - [really] fix the report path
> - log the output of make config in the proper file
> 
> v2->v3:
> - fix when not launched from dpdk root dir
> - use "-Og -Wno-error" instead of "-O0"
> - fix typo in commit log
> 
> v1->v2:
> - use /usr/bin/env to find bash (which is required)
> - fix displayed path to html reports
> - reword help for -f option
> 
>  devtools/validate-abi.sh | 397 ++++++++++++++++++++++++-----------------------
>  1 file changed, 205 insertions(+), 192 deletions(-)
> 

To reiterate with updated logging
Acked-by: Neil Horman <nhorman at tuxdriver.com>



More information about the dev mailing list