[dpdk-dev] [PATCH v2] hash: fix incorrect eviction counter

Thomas Monjalon thomas at monjalon.net
Sat Oct 7 00:10:36 CEST 2017


22/09/2017 15:46, Bruce Richardson:
> On Fri, Sep 22, 2017 at 05:25:43AM +0100, Pablo de Lara wrote:
> > When adding a new entry in a hash table, there is
> > a maximum number of evictions that can be
> > performed. When the counter of these evictions reaches
> > this maximum, the entry cannot be added, as it is considered
> > that the algorithm has encountered an infinite loop.
> > 
> > The problem with the current implementation, is that this
> > counter was declared as a static variable.
> > If there are multiple threads adding entries in the same table
> > or in different tables, they should access different counters,
> > one per core and per table.
> > 
> > Therefore, the variable has been modified to be non-static.
> > 
> > Fixes: 243e93a5046f ("hash: fix unlimited cuckoo path")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Applied, thanks


More information about the dev mailing list