[dpdk-dev] [PATCH 0/3] Extend port and queue attribute get functions
Jerin Jacob
jerin.jacob at caviumnetworks.com
Sun Oct 8 15:53:05 CEST 2017
-----Original Message-----
> Date: Wed, 4 Oct 2017 14:12:50 +0000
> From: "Van Haaren, Harry" <harry.van.haaren at intel.com>
> To: "Eads, Gage" <gage.eads at intel.com>, "dev at dpdk.org" <dev at dpdk.org>
> CC: "jerin.jacob at caviumnetworks.com" <jerin.jacob at caviumnetworks.com>
> Subject: RE: [PATCH 0/3] Extend port and queue attribute get functions
>
> > From: Eads, Gage
> > Sent: Wednesday, September 20, 2017 4:21 PM
> > To: dev at dpdk.org
> > Cc: jerin.jacob at caviumnetworks.com; Van Haaren, Harry
> > <harry.van.haaren at intel.com>
> > Subject: [PATCH 0/3] Extend port and queue attribute get functions
> >
> > This patchset makes the full queue and port configuration structures
> > accessible
> > through the attribute get functions, adds tests for the new attributes, and
> > fixes one bug in a port attribute get test.
> >
> > This patchset is based on patches 29019 through 29023.
> >
> > Gage Eads (3):
> > eventdev: extend queue attribute get function
> > eventdev: extend port attribute get function
> > test/eventdev: fix bug in port enqueue depth test
> >
> > lib/librte_eventdev/rte_eventdev.c | 125 ++++++++++++--------------
> > lib/librte_eventdev/rte_eventdev.h | 26 ++++--
> > test/test/test_eventdev.c | 179
> > +++++++++++++++++++++++++++++++++++--
> > 3 files changed, 245 insertions(+), 85 deletions(-)
>
> Thanks - good to see the attrs API get more value!
>
> Series-Reviewed-by: Harry van Haaren <harry.van.haaren at intel.com>
Applied after fixing the build issue found in my system(gcc 7.2.0) to dpdk-next-eventdev/master. Thanks.
== Build test/cmdline_test
CC test_eventdev.o
In file included from
/export/dpdk-next-eventdev/test/test/test_eventdev.c:41:0:
/export/dpdk-next-eventdev/test/test/test_eventdev.c: In function
‘test_eventdev_queue_attr_event_queue_cfg’:
/export/dpdk-next-eventdev/test/test/test.h:149:4: error: ‘i’ may be
used uninitialized in this function [-Werror=maybe-uninitialized]
printf("TestCase %s() line %d failed (err %d): " \
^~~~~~
/export/dpdk-next-eventdev/test/test/test_eventdev.c:494:6: note: ‘i’
was declared here
int i, ret;
^
➜ [master][dpdk-next-eventdev] $ git diff
diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
index 1d9e9fe4c..de3a964c2 100644
--- a/test/test/test_eventdev.c
+++ b/test/test/test_eventdev.c
@@ -505,7 +505,7 @@ test_eventdev_queue_attr_event_queue_cfg(void)
"Queue count get failed");
ret = rte_event_queue_default_conf_get(TEST_DEV_ID, 0, &qconf);
- TEST_ASSERT_SUCCESS(ret, "Failed to get queue%d def conf", i);
+ TEST_ASSERT_SUCCESS(ret, "Failed to get queue0 def conf");
qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_PARALLEL_ONLY;
More information about the dev
mailing list