[dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize

Ferruh Yigit ferruh.yigit at intel.com
Mon Oct 9 06:21:00 CEST 2017


On 8/22/2017 3:03 AM, Xing, Beilei wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Daniel Mrzyglod
>> Sent: Friday, August 18, 2017 10:18 PM
>> To: Xing, Beilei <beilei.xing at intel.com>
>> Cc: dev at dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod at intel.com>
>> Subject: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to
>> determine filesize
>>
>> This issue was about passing unsigned argument where should be signed
>> number.
>> In reality this is about wrong usage of fseek and ftell to determine filesize.
>> This patch is compliant to suggestions from FIO19-C:
>> "Do not use fseek() and ftell() to compute the size of a regular file"
>>
>> Coverity issue: 143454
>> Fixes: a92a5a2cbbff ("app/testpmd: add command for loading DDP")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>
> 
> Acked-by: Beilei Xing <beilei.xing at intel.com>

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list