[dpdk-dev] [PATCH] Sort list of entries in examples.dox

Luca Boccassi bluca at debian.org
Mon Oct 9 15:51:20 CEST 2017


On Mon, 2017-10-09 at 15:24 +0200, Bernhard M. Wiedemann wrote:
> so that dpdk builds in a reproducible way
> in spite of indeterministic filesystem readdir order
> 
> using LC_ALL=C for sorting to be independent of locales
> 
> Signed-off-by: Bernhard M. Wiedemann <bwiedemann at suse.de>
> ---
>  mk/rte.sdkdoc.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk
> index c0eaa3502..8f2f58e73 100644
> --- a/mk/rte.sdkdoc.mk
> +++ b/mk/rte.sdkdoc.mk
> @@ -93,7 +93,7 @@ $(API_EXAMPLES): api-html-clean
>  	$(Q)mkdir -p $(@D)
>  	@printf '/**\n' > $(API_EXAMPLES)
>  	@printf '@page examples DPDK Example Programs\n\n' >>
> $(API_EXAMPLES)
> -	@find examples -type f -name '*.c' -printf '@example %p\n'
> >> $(API_EXAMPLES)
> +	@find examples -type f -name '*.c' | LC_ALL=C sort | xargs
> -l echo "@example" >> $(API_EXAMPLES)
>  	@printf '*/\n' >> $(API_EXAMPLES)
>  
>  guides-pdf-clean: guides-pdf-img-clean

Hello Bernhard,

If you are interested in reproducible builds please have a look at this
patch series I submitted a while ago:

http://dpdk.org/dev/patchwork/patch/28386/

I have verified that those patches make the build reproducible on
Debian (x86/x86_64/arm64).

Feedback from SUSE is very welcome!

-- 
Kind regards,
Luca Boccassi


More information about the dev mailing list