[dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd driver

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Saturday, October 7, 2017 9:28 PM
> To: dev at dpdk.org
> Cc: mw at semihalf.com; dima at marvell.com; nsamsono at marvell.com;
> Jianbo.liu at linaro.org; Tomasz Duszynski <tdu at semihalf.com>; Jacek Siuda
> <jck at semihalf.com>
> Subject: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd
> driver

...

> diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c
> b/drivers/crypto/mrvl/rte_mrvl_pmd.c
> new file mode 100644
> index 0000000..a404bf4
> --- /dev/null
> +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c

...

> +
> +/* Register the driver in constructor. */
> +RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_MRVL_PMD,
> cryptodev_mrvl_pmd_drv);
> +RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD,
> +	"max_nb_queue_pairs=<int> "
> +	"max_nb_sessions=<int> "
> +	"socket_id=<int>");
> +RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_mrvl_pmd_drv,
> cryptodev_driver_id);

This macro now needs 3 parameters. You probably rebased the patchset
against the main repo, and not dpdk-next-crypto.
Just a reminder that all crypto patches should target this repository.

Apart from this, the rest of the patchset looks good to me.
So send a v4 and hopefully it can be merged in RC1.

Pablo