[dpdk-dev] [PATCH v3 3/4] cryptodev: rework dependency on vdev header

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Oct 10 14:49:31 CEST 2017



> -----Original Message-----
> From: jblunck at gmail.com [mailto:jblunck at gmail.com] On Behalf Of Jan
> Blunck
> Sent: Tuesday, October 10, 2017 12:30 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Cc: dev at dpdk.org; Doherty, Declan <declan.doherty at intel.com>
> Subject: Re: [PATCH v3 3/4] cryptodev: rework dependency on vdev header
> 
> On Tue, Oct 10, 2017 at 10:47 AM, De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Jan Blunck [mailto:jblunck at gmail.com] On Behalf Of Jan Blunck
> >> Sent: Friday, October 6, 2017 9:40 AM
> >> To: dev at dpdk.org
> >> Cc: Doherty, Declan <declan.doherty at intel.com>; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch at intel.com>
> >> Subject: [PATCH v3 3/4] cryptodev: rework dependency on vdev header
> >>
> >> The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers.
> >> By moving the helper to the header we don't require rte_vdev.h at
> >> build- time of the librte_cryptodev library. This is a preparation to
> >> move the vdev bus into a standalone library.
> >>
> >> Signed-off-by: Jan Blunck <jblunck at infradead.org>
> >
> > This looks good, but could you also remove the deprecation notice from
> the previous release?
> > Apart from that:
> >
> 
> I wondered about that too. The message said that it will be static from
> 17.11 on and I wonder if we should actually keep it into the notes for this
> release.

Well, actually this change should be added in release notes (under API changes, I think),
and removed from deprecation.rst.

Thanks,
Pablo



More information about the dev mailing list